Resolve Ansible Builder Errors for Podman on Windows #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue for Podman on Windows, which copies over executable files without the executable bit on, which causes subsequent Containerfile steps to fail. By explicitly marking copied files as executable, this issue is remedied, and Ansible Builder is made usable on more platforms.
Since Containerfiles use a POSIX-like syntax, and I don't believe that Windows containers are supported base images, I think it's safe to say that Windows hosts should not insert backslash characters into entrypoint path for their Containerfiles.
This adds a unit test to make sure that when Windows NT path separator characters are preferred by os.path, the entrypoint will still be defined with POSIX path separators.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team!
I recently tried using Ansible Builder to create Ansible execution environments on my Windows machine with Podman, and I ran into a few issues.
ENTRYPOINTpath, preventing the container from running.These changes add the
--chmodflag to theCOPYcommands in the Containerfile, ensuring the scripts run correctly and ensuring behavioral parity between Podman and Docker. They also use the POSIX path separator when creating theENTRYPOINTdirective.I've added unit tests to validate the path character behavior, and I've updated existing tests for the COPY directive. After applying these changes, I was able to use Ansible Builder to create a container with a usable Ansible installation inside (using Fedora as the base image).
If you guys could incorporate these changes into the project when you get the chance, I would deeply appreciate it (and please let me know if there is anything else I can do)!
Sincerely,
Kevin