-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor plugin to use AnActionListener on messageBus #90
base: main
Are you sure you want to change the base?
Conversation
instead of hooking into ideavim internals. Also fixes a bug with gg/zz leaving a dangling popup at the end of the sequence.
We could let jetbrains know at https://youtrack.jetbrains.com/issue/VIM-3085 after merging (if we merge) |
This new code now also allows to intercept Escape, so I added a commit that allows closing the which-key popup using escape. But I now noticed that it isn't quite that simple, it should also check if which-key is even open and that ESC isn't a valid target given the current key sequence. I'll add that in the coming days. |
like which-key.nvim does
4f4e50b
to
22ace42
Compare
Implemented this now, good to go 👍 |
I think because this acts after key press now (at least for non-special keys) that it probably broke |
I just tested your PR now with the following set which-key
set notimeout
let g:WhichKey_ShowVimActions = "true" Also pressing for example |
Strange, these are all things that should work and that I tested. But not with a minimal config but instead with my lazyvim-oriented config (cufarvid/lazy-idea#3). |
Tested this with your example config. Very weird, for me Will need to investigate further. |
Okay, interesting learning: |
because these sequences don't get tracked in mappingState if there is no matching user binding. Instead, they are tracked in commandBuilder.
I pushed a fix for my own |
This still does not explain why |
I usually test by building the plugin and installing it locally (as |
instead of hooking into ideavim internals.
Also fixes some minor mapping bugs.
g:WhichKeyProcessUnknownMappings=false
still works with thisFixes #88
Fixes #81
Fixes #71
Fixes #52