Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom keystroke translation #91

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

luqasn
Copy link
Contributor

@luqasn luqasn commented Feb 9, 2025

Fixes #89

@TheBlob42
Copy link
Owner

I just checked this PR independently with the example you have provided in #89

But this does not open the popup for me at all. Did you test this with the change of another of your PRs together to get it to work?

BTW thanks for all the contributions ❤️ and sorry that it takes so long for me to review them, as I am currently a little occupied by work 🙈

@luqasn
Copy link
Contributor Author

luqasn commented Feb 9, 2025

Hey, don't worry about it! I am currently on vacation, usually I am also not always that keen to continue programming after doing that for the day job :)

Yes, I originally tested this as part of #90 but didn't want to do too many changes together.

I guess the main thing to test here is that it does not break existing stuff and then we can check after merging this if the descriptions work in the other PR.
I tested \\ handling for example because I removed the custom bit for that.
And my <leader> bindings also still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifiers in descriptions are case-sensitive
2 participants