fix: Homepage no longer downloaded on script #6230
Open
+17
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrapped GET homepage logic in an if/else. I am not sure if this is the best option, or if this is breaking at all (I don't think it is but I'm not completly sure)
Motivation and Context
Currently checkver.ps1 GETs the homepage, even if script is specified, and does nothing with it. This becomes an issue when the homepage doesn't return a 2xx, like a timeout, or a 403 Forbiden (like cloudflare does). I don't see any reason this is the case.
For example
fixes #5704,
closes #6090 (was merging with master)
How Has This Been Tested?
Checklist:
develop
branch.