fix: Homepage no longer downloaded on script #6090
Open
+17
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrgzs
approved these changes
Nov 11, 2024
|
I encountered this problem recently. I don't understand how this is designed, which means that the app will not be updated when its website runs away? Hope to fix this as soon as possible. |
5 tasks
|
This was not targeting develop, #6230 now is. I also added an example there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
checkver.ps1GETs the homepage, even ifscriptis specified, and does nothing with it. This becomes an issue when the homepage doesn't return a 2xx, like a timeout, or a403 Forbiden(like cloudflare does). I don't see any reason this is the case, so I wrapped this logic in an if/else. I am not sure if this is the best option, or if this is breaking at all (I don't think it is but I'm not completly sure)fixes #5704.
PS: I'm not sure if I'm supposed to create the PR to the master branch or the develop branch (CONTRIBUTING.md isn't really clear on that). Right now they're synced so it shouldn't be an issue.