MultiCI: Abstract Github Action cache access behind type #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Nava2
changed the title
Nava2
force-pushed
the
kevin/abstract-gha/abstract-exec
branch
from
7dea2ba to
ae9ebde
Compare
Nava2
force-pushed
the
kevin/abstract-gha/abstract-cache-2
branch
from
790b0bc to
d5de794
Compare
Nava2
commented
Jan 9, 2025
| } | ||
|
|
||
| async restoreCache(paths: string[], primaryKey: string, restoreKeys?: string[], options?: RemoteCacheDownloadOptions): Promise<GradleEnvCacheEntry | undefined> { | ||
| for (const key in [primaryKey, ...(restoreKeys ?? [])]) { |
There was a problem hiding this comment.
Admittedly, this is a pretty reasonable code implementation if we swapped out the direct file read/write for use in a non-gh-action world.
Nava2
force-pushed
the
kevin/abstract-gha/abstract-exec
branch
from
ae9ebde to
8b6a14f
Compare
Nava2
force-pushed
the
kevin/abstract-gha/abstract-cache-2
branch
from
d5de794 to
05652f8
Compare
This was referenced Jan 9, 2025
Nava2
changed the title
Nava2
force-pushed
the
kevin/abstract-gha/abstract-exec
branch
from
8b6a14f to
e51a1a8
Compare
Nava2
force-pushed
the
kevin/abstract-gha/abstract-cache-2
branch
from
751d4d0 to
d303a37
Compare
Nava2
force-pushed
the
kevin/abstract-gha/abstract-exec
branch
from
e51a1a8 to
02206f4
Compare
Nava2
force-pushed
the
kevin/abstract-gha/abstract-cache-2
branch
from
d303a37 to
7049568
Compare
There is no functional changes present, access is moved behind class instead.
This reverts commit 751d4d0.
Nava2
force-pushed
the
kevin/abstract-gha/abstract-exec
branch
from
02206f4 to
3c45f8f
Compare
Nava2
force-pushed
the
kevin/abstract-gha/abstract-cache-2
branch
from
7049568 to
b5b36e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no functional changes present, access is moved behind small wrapper class to provide a simple abstraction to be replaced.
Currently, we implement this in terms of
Github Actions-- for obvious reasons. In the future, this enables implementation in other, non-Github CI environments.Part of gradle#502.