MultiCI: Abstract state reading #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 9, 2025
This adds a new pattern for abstracting away the "github action"-specific code within the github actions. The overall intention is to perform this change for all of the `@actions/xxx` libraries in use to enable implementation of these features within other environments (e.g. Jenkins, BuildKite, GitLab). Part of gradle#502.
Nava2
force-pushed
the
kevin/abstract-gha/abstract-state-reading
branch
from
b2d72ed to
842c685
Compare
Nava2
added a commit
that referenced
this pull request
Jan 9, 2025
Following #18, we finish replacing all usages. This was split to enable easier review and acknowledge there's a couple small behaviour changes using `true.toString()` for example. Part of gradle#502.
This was referenced Jan 9, 2025
Nava2
added a commit
that referenced
this pull request
Jan 9, 2025
Following #18, we finish replacing all usages. This was split to enable easier review and acknowledge there's a couple small behaviour changes using `true.toString()` for example. Part of gradle#502.
Nava2
added a commit
that referenced
this pull request
Jan 10, 2025
Following #18, we finish replacing all usages. This was split to enable easier review and acknowledge there's a couple small behaviour changes using `true.toString()` for example. Part of gradle#502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no functional changes present, access is moved behind small wrapper class to provide a simple abstraction to be replaced.
Currently, we implement this in terms of
Github Actions-- for obvious reasons. In the future, this enables implementation in other, non-Github CI environments.#22 contains all usages replaced directly.
Part of gradle#502.