Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageDecoder: Port to Windows #2952

Merged
merged 2 commits into from
Feb 14, 2025
Merged

ImageDecoder: Port to Windows #2952

merged 2 commits into from
Feb 14, 2025
+129 −6

Conversation

stasoid
Copy link
Contributor

@stasoid stasoid commented Dec 17, 2024 •
edited
Loading

No description provided.

@stasoid stasoid marked this pull request as draft December 26, 2024 06:00
@stasoid stasoid marked this pull request as ready for review January 7, 2025 10:20
@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 29, 2025
@stasoid
Copy link
Contributor Author

stasoid commented Jan 29, 2025

.

@github-actions github-actions bot removed the stale label Jan 30, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

@github-actions github-actions bot added the conflicts Pull request has merge conflicts that need resolution label Feb 6, 2025
@github-actions github-actions bot added conflicts Pull request has merge conflicts that need resolution and removed conflicts Pull request has merge conflicts that need resolution labels Feb 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest master.

@github-actions github-actions bot removed the conflicts Pull request has merge conflicts that need resolution label Feb 7, 2025
@stasoid stasoid mentioned this pull request Feb 13, 2025
Open
@stasoid stasoid force-pushed the imgdec branch 3 times, most recently from 50a9616 to 05c0446 Compare February 14, 2025 07:19
ADKaster
ADKaster approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@ADKaster ADKaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this seems quite pleasant. I suspect we'll need to iterate on the windows_socketpair implementation over time, especially given the known limitations of using TCP for it that have come about over time on other projects.

@ADKaster ADKaster merged commit 7789472 into LadybirdBrowser:master Feb 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADKaster ADKaster ADKaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stasoid @ADKaster