ImageDecoder: Port to Windows

LadybirdBrowser · Feb 14, 2025 · bdb747d · bdb747d
1 parent 9e5efef
commit bdb747d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/Libraries/LibThreading/CMakeLists.txt b/Libraries/LibThreading/CMakeLists.txt
@@ -7,5 +7,7 @@ serenity_lib(LibThreading threading)
 target_link_libraries(LibThreading PRIVATE LibCore)
 
 if (WIN32)
+    find_package(pthread REQUIRED)
+    target_include_directories(LibThreading PUBLIC $<BUILD_INTERFACE:${PTHREAD_INCLUDE_DIR}>)
     target_link_libraries(LibThreading PUBLIC ${PTHREAD_LIBRARY})
 endif()
diff --git a/Services/ImageDecoder/CMakeLists.txt b/Services/ImageDecoder/CMakeLists.txt
@@ -21,5 +21,5 @@ add_executable(ImageDecoder main.cpp)
 target_include_directories(imagedecoderservice PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/../..)
 target_include_directories(imagedecoderservice PRIVATE ${LADYBIRD_SOURCE_DIR}/Services/)
 
-target_link_libraries(ImageDecoder PRIVATE imagedecoderservice LibCore LibMain)
+target_link_libraries(ImageDecoder PRIVATE imagedecoderservice LibCore LibMain LibThreading)
 target_link_libraries(imagedecoderservice PRIVATE LibCore LibGfx LibIPC LibImageDecoderClient LibMain LibThreading)
diff --git a/Services/ImageDecoder/ConnectionFromClient.cpp b/Services/ImageDecoder/ConnectionFromClient.cpp
@@ -57,8 +57,8 @@ ErrorOr<IPC::File> ConnectionFromClient::connect_new_client()
 
     auto client_socket_or_error = Core::LocalSocket::adopt_fd(socket_fds[0]);
     if (client_socket_or_error.is_error()) {
-        close(socket_fds[0]);
-        close(socket_fds[1]);
+        (void)Core::System::close(socket_fds[0]);
+        (void)Core::System::close(socket_fds[1]);
         return client_socket_or_error.release_error();
     }