-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load cell gram scale #6729
base: master
Are you sure you want to change the base?
Load cell gram scale #6729
Conversation
The tests failed because of the numpy dependency. I guess I could move the check out of |
such a pity numpy is so bloaty and time consuming to just add it to requirements |
I'm not sure that this has a real world impact. I guess most, or at least a significant portion also use input shaping and have it installed anyway. |
i think its the sheer time to compile numpy is the issue if the host is sub par, it can take hours on some |
I would love to get on my "just require numpy" soap box (Binaries are installed automatically for 32bit, you don't need to compiling it. Its shockingly fast vs plain python. "Your job as a Python programmer is to write C") but... I want to ship this and be 'done' with the project. So what do I have to do? I can push the numpy require check back to the point where its clear that you are configuring a probe. Most of what I'm using it for in this PR ( For probing, I need |
Is there any way to provide / use a prebuilt v1.26 wheel? |
|
||
This document describes Klipper's support for load cells and load cell based | ||
probes. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not knowing what a load cell does/means for a 3d printer, could you add a sentence or two describing it's usage/benefits for 3d printers/klipper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some updates to the documentation including a little bit more exposition at the top and a section about how to read the load cell gram force
* Convert sensor counts to grams and make this available via unix socket and object status * Basic GCodes for tearing and reading the load cell * Guided Calibration * Diagnostic gcode to check the health of the load cell Signed-off-by: Gareth Farrington <[email protected]>
Signed-off-by: Gareth Farrington <[email protected]>
270aa4f
to
a3f6aa5
Compare
* Add API server load_cell/dump_force endpoint * Update [load_cell] config with calibration fields * Add G-Code commands for working with load cells * Add status reference for load_cell objects Signed-off-by: Gareth Farrington <[email protected]>
a3f6aa5
to
dde606a
Compare
For users: if you use Python 3.0 on a 32 bit RPI OS then PiWheels will just install a binary. That's the default behavior. You have to kinda work hard to not get that to happen. i.e. willfully use Python 2 or pick a 64 bit OS. For the git build system: I'm not sure how that works. |
PyPi has some arm64 wheels as well
There are examples of project who built the necessary wheels as CI actions. E.g. https://github.com/matrix-org/synapse/pull/14212/files Maybe it would be an option to built the needed wheels (Python 2 and Python3?) as Klipper CI and the install scripts (or KIAUH) could automatically draw upon them. |
This was updated to remove the numpy dependency |
This PR adds the features needed to make a load cell actually work as a gram scale. This PR will let you weight filament or measure a force in grams. (no homing or probing yet!)
counts
to grams and make this force data available via unix socket and printer object statusThis code has been tested by several people in the community and some last minute bug fixes and changes were landed:
reverse
option allows the polarity of the force readings to be inverted. You can have your probing collision graphs in either orientation now.reference_tare_counts
is written to config and read as an integer. linkCALIBRATE
was used beforeTARE
A lot of work (months) and bug fixing went into parts of this, particularly
LOAD_CELL_DIAGNOSTIC
and theLoadCellSampleCollector
. These bits have to work when the sensor is buggy and still produce usable output.LoadCellSampleCollector
also underpins later work for probing.numpy
is required for this PR. We could change that. But PR's for probing will absolutely need it. If you want to merge[load_cell]
and[load_cell_probe]
then it seems there is no point in trying to keep it out of this PR.