Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resonance_tester: Fix chips selection, add accel_per_hz selection #6726

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

MRX8024
Copy link
Contributor

@MRX8024 MRX8024 commented Oct 30, 2024

-The current code does not have the option to "live" select a non-adxl345 chips when running TEST_RESONANCES, since it adds the adxl prefix by default.
-Added the ability to "live" select accel_per_hz when running TEST_RESONANCES.
-Minor fixes in the documentation.

Signed-off-by: Maksim Bolgov [email protected]

@nefelim4ag
Copy link
Contributor

Every commit is expected to have a sign-off line.
PR on the other hand can just have a basic description, arguing, and description of a problem:
why it is a problem and how you are trying to solve it.

Also, take a look at: https://www.klipper3d.org/CONTRIBUTING.html
Specifically the commit format.

Thanks.

@MRX8024 MRX8024 force-pushed the master branch 2 times, most recently from e9ff1b9 to c295ab0 Compare October 31, 2024 23:25
@MRX8024
Copy link
Contributor Author

MRX8024 commented Oct 31, 2024

Thanks for the tip, I think I fixed the formatting of the commits

@dmbutyugin
Copy link
Collaborator

Thanks. I think this makes sense. However, given that this is a not a backwards-compatible change, I think it should be mentioned in docs/Config_Changes.md that the CHIPS= parameter for TEST_RESONANCES and SHAPER_CALIBRATE commands must specify the full accelerometer name(s).

@MRX8024
Copy link
Contributor Author

MRX8024 commented Nov 11, 2024

the full accelerometer name(s).

Do you want me to add a straight CHIPS=<full_chip_name>, or just description?
The doc already mentions: "for example CHIPS="adxl345, adxl345 rpi"".
Thanks

@dmbutyugin
Copy link
Collaborator

I think the G-Codes documentation is OK already. But since this is a change that will break any existing usages of CHIPS parameter, it is better to document this in docs/Config_Changes.md (it says 'config', however breaking gcode changes are also documented there).

Corrected issue where accelerometer names were incorrectly prefixed
with "adxl345", preventing the selection of other chip types when running TEST_RESONANCES.

Signed-off-by: Maksim Bolgov [email protected]
Implemented support for selecting the `accel_per_hz` parameter when running TEST_RESONANCES.

Signed-off-by: Maksim Bolgov [email protected]
…rs and bracket corrections

Signed-off-by: Maksim Bolgov [email protected]
@dmbutyugin
Copy link
Collaborator

Thanks!

@KevinOConnor KevinOConnor merged commit 6d1256d into Klipper3d:master Nov 13, 2024
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants