Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Motion #442

Merged
merged 100 commits into from
Sep 19, 2024

Suggested changes

e416800
Select commit
Loading
Failed to load commit list.
Merged

New Motion #442

Suggested changes
e416800
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 19, 2024 in 0s

89.86% (target 90.00%)

View this Pull Request on Codecov

89.86% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 80.33827% with 93 lines in your changes missing coverage. Please review.

Project coverage is 89.86%. Comparing base (4862b40) to head (e416800).

Files with missing lines Patch % Lines
KomaMRIPlots/src/ui/DisplayFunctions.jl 75.90% 20 Missing ⚠️
KomaMRIBase/src/motion/motionlist/SpinSpan.jl 26.08% 17 Missing ⚠️
KomaMRIBase/src/motion/nomotion/NoMotion.jl 23.80% 16 Missing ⚠️
KomaMRIFiles/src/Phantom/Phantom.jl 85.29% 10 Missing ⚠️
KomaMRIBase/src/motion/motionlist/MotionList.jl 88.23% 8 Missing ⚠️
KomaMRIBase/src/datatypes/Phantom.jl 76.47% 4 Missing ⚠️
KomaMRIBase/src/motion/motionlist/TimeSpan.jl 78.94% 4 Missing ⚠️
...e/src/motion/motionlist/actions/ArbitraryAction.jl 89.47% 4 Missing ⚠️
KomaMRIBase/src/motion/motionlist/Motion.jl 85.00% 3 Missing ⚠️
.../motion/motionlist/actions/simpleactions/Rotate.jl 86.36% 3 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   90.93%   89.86%   -1.07%     
==========================================
  Files          53       54       +1     
  Lines        2934     3050     +116     
==========================================
+ Hits         2668     2741      +73     
- Misses        266      309      +43
Files with missing lines Coverage Δ
KomaMRIBase/src/KomaMRIBase.jl 100.00% <ø> (ø)
KomaMRIBase/src/motion/motionlist/Action.jl 100.00% <100.00%> (ø)
...Base/src/motion/motionlist/actions/SimpleAction.jl 100.00% <100.00%> (ø)
...tion/motionlist/actions/simpleactions/HeartBeat.jl 100.00% <100.00%> (ø)
KomaMRICore/ext/KomaoneAPIExt.jl 92.59% <ø> (ø)
KomaMRICore/src/KomaMRICore.jl 100.00% <ø> (ø)
KomaMRICore/src/simulation/Flow.jl 100.00% <100.00%> (ø)
KomaMRICore/src/simulation/Functors.jl 91.30% <100.00%> (+5.59%) ⬆️
...RICore/src/simulation/SimMethods/Bloch/BlochCPU.jl 100.00% <100.00%> (ø)
...RICore/src/simulation/SimMethods/Bloch/BlochGPU.jl 100.00% <100.00%> (ø)
... and 15 more

... and 4 files with indirect coverage changes

View more details on Codecov