Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SCENARIO_SPECIFIC and PROFESSION_SPECIFIC eoc types #79448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove SCENARIO_SPECIFIC and PROFESSION_SPECIFIC eoc types #79448

wants to merge 1 commit into from

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Both SCENARIO_SPECIFIC and PROFESSION_SPECIFIC eocs are no different from activation EoCs, and we already restrict the code to run only EoCs listed in scenario/profession, no reason to do it twice

Describe the solution

Remove both types

Testing

TBD

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON labels Jan 31, 2025
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs labels Jan 31, 2025
@github-actions github-actions bot requested a review from KorGgenT January 31, 2025 11:11
@github-actions github-actions bot added the Scenarios New Scenarios, balancing, bugs with scenarios label Jan 31, 2025
@github-actions github-actions bot requested a review from Maleclypse January 31, 2025 11:11
@github-actions github-actions bot added Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Aftershock Anything to do with the Aftershock mod Mods: Defense Mode Anything to do with the Defense Mode mod EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved Mods: Sky Island Anything about the Sky Island mod Mods: Isolation Protocol ☣ The total conversion mod Isolation Protocol astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Aftershock Anything to do with the Aftershock mod Mods: Defense Mode Anything to do with the Defense Mode mod Mods: Isolation Protocol ☣ The total conversion mod Isolation Protocol Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Sky Island Anything about the Sky Island mod Mods: Xedra Evolved Anything to do with Xedra Evolved Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GuardianDll