-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magic Infrastructure: Split NON_MAGICAL into ALWAYS_CASTABLE and IGNORES_SPELL_RESISTANCE #79205
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This will break Astral Projection (which relies on none of your powers being usable except the one to stop projecting) and also break the ability to stop concentrating on something if you're unable to use your powers but still concentrate. Edit: for example, if you're too tired you can't channel anything but you can still end concentration. |
Adjusted the PR to split the flag into two |
Summary
Infrastructure "Split NON_MAGICAL into ALWAYS_CASTABLE and IGNORES_SPELL_RESISTANCE"
Purpose of change
Initially Brought up in discord
NON_MAGICAL has two separate functions, ignoring spell resistance and preventing various status that prevent spellcasting from touching the spell. There's times when a spell may want only one of the statuses. Also, I don't think NON_MAGICAL describes either of these two functions very well either, so the new names would make it more specific.
Describe the solution
Split NON_MAGICAL into ALWAYS CASTABLE and IGNORES_SPELL_RESISTANCE flags to better clarify their function and allow using one without the other.
Move the existing uses to ALWAYS CASTABLE or IGNORES_SPELL_RESISTANCE based on what the spell is supposed to do.
Describe alternatives you've considered
N/A
Testing
Did a quick check by adding NON_MAGICAL to a spell with cannot_cast_flags and confirmed that it was blocked
Additional context