Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead code #79004

Merged
merged 1 commit into from
Jan 8, 2025
Merged

remove dead code #79004

merged 1 commit into from
Jan 8, 2025

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented Jan 7, 2025

Summary

None

Purpose of change

Remove dead code.

Describe the solution

Describe alternatives you've considered

Use it to replace instances of m_runtimes[ id ].reset( def );, which I didn't realize at first is adding to m_runtimes by reset to def.

Testing

Should compile.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 7, 2025
@Brambor Brambor marked this pull request as draft January 7, 2025 15:27
@Brambor Brambor marked this pull request as ready for review January 7, 2025 15:28
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 7, 2025
@GuardianDll GuardianDll merged commit 3b1ad40 into CleverRaven:master Jan 8, 2025
36 of 44 checks passed
@Brambor Brambor deleted the remove-dead-code branch January 8, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants