Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add some exclude options for slither #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add some exclude options for slither #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion slither.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"detectors_to_exclude": "block-timestamp",
"detectors_to_exclude": "block-timestamp, reentrancy-events, solc-version",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @snowwhitedev , could you explain, why do you want to disable those detectors?
I think its OK to get notifications about potential "reentrancy-events" and disable warnings with commenting. (I understand that reentrancy-events works buggy and sometimes false detects)
solc-version can be helpful too to keep compiler fresh. Isn't it?

Tell me please, your reasons.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oleggrib
Regarding reentrancy-events, slither even though we took count the case. I faced this several times when I used slither in my local. For example you can see this. #5 (comment)

Regarding solc-version, in most cases we are using dependencies such as openzepplin-contracts when writing smart contract. They includes several solidity versions, so slither shows warning or error message.

"filter_paths": "(helpers/|node_modules/)"
}