chore: add some exclude options for slither #6
Conversation
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "detectors_to_exclude": "block-timestamp", | |||
| "detectors_to_exclude": "block-timestamp, reentrancy-events, solc-version", | |||
There was a problem hiding this comment.
Hi, @snowwhitedev , could you explain, why do you want to disable those detectors?
I think its OK to get notifications about potential "reentrancy-events" and disable warnings with commenting. (I understand that reentrancy-events works buggy and sometimes false detects)
solc-version can be helpful too to keep compiler fresh. Isn't it?
Tell me please, your reasons.
There was a problem hiding this comment.
Hi @oleggrib
Regarding reentrancy-events, slither even though we took count the case. I faced this several times when I used slither in my local. For example you can see this. #5 (comment)
Regarding solc-version, in most cases we are using dependencies such as openzepplin-contracts when writing smart contract. They includes several solidity versions, so slither shows warning or error message.
No description provided.