Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error bundling wheels for Python Secrets SDK #295

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Nov 14, 2024

What It Does

Fixes an error in the nightly bundle workflow: curl: (3) URL using bad/illegal format or missing URL
https://github.com/zowe/zowe-cli-standalone-package/actions/runs/11828092184/job/32957527889

How to Test

Run the updated cURL command locally - it should print a list of only valid URLs:

curl -fs https://pypi.org/project/zowe-secrets-for-zowe-sdk/#files |
  grep -Eo 'href="https://[^"]+\.whl"' | cut -d '"' -f 2 |

Review Checklist
I certify that I have:

Additional Comments

@t1m0thyj t1m0thyj marked this pull request as ready for review November 14, 2024 14:01
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋
Thanks for removing the selected invalid URLs from the list 🙏
image

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the easy testing steps!

@t1m0thyj t1m0thyj merged commit 7ad3395 into master Nov 14, 2024
6 checks passed
@t1m0thyj t1m0thyj deleted the fix/create-pysdk-bundle branch November 14, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants