Allow accessing deleted associations #3
Conversation
|
This used to be such a nice and simple library… Before going too far with this, please make sure that it works on #2 as well. |
|
Fucking edge cases... We're trying to avoid having to merge this in. |
|
@dasch could I convince you to resurrect this for: https://zendesk.atlassian.net/browse/HC-2710? @vkmita has a different approach as well, here: #4 |
|
Hah I remember hacking that. It was fun. |
dasch
force-pushed
the
dasch/deleted-associations
branch
2 times, most recently
from
87fbfc8 to
7032179
Compare
Adds a `with_deleted_associations` method that returns the object in a wrapper that checks all method calls. Those that correspond to associations are modified such that deleted associated records are included in the result.
dasch
force-pushed
the
dasch/deleted-associations
branch
from
7032179 to
698ea2b
Compare
|
|
||
| def method_missing(name, *args, &block) | ||
| delegate_to_record(name) { @record.public_send(name, *args, &block) } | ||
| end |
There was a problem hiding this comment.
As recently as yesterday I ran into problems because of meta magic like this in Dynamic Content. Basically breaking ActiveModel::AttributeMethods and ActiveRecord::AttributeMethods reflection because we catch methods first.
There was a problem hiding this comment.
I think if DC started using BasicObject those issues would go away.
There was a problem hiding this comment.
I have my share of scar tissue.
|
@dasch why aren't you using |
|
With some reluctance: 👍 I really wish we weren't unwrapping (through wrapping) our default scopes. Maybe this should be hard-coded at the model layer. Calling extend on instances is no longer prohibitive, due to improvements on GC. Yadayada. |
|
👍 |
Allow accessing deleted associations
Adds a
with_deleted_associationsmethod that returns the object in a wrapper that checks all method calls. Those that correspond to associations are modified such that deleted associated records are included in the result.@bastien please review.