Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodes #16

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

add nodes #16

wants to merge 38 commits into from

Conversation

noobusdeer
Copy link

Add some nodes
CAR
CDR
DeleteSlice
Reader
GetSlice
GetSpread Advanced
Sort Advanced
Unzip
Occurrence

@zauner
Copy link
Owner

zauner commented Aug 19, 2014

Thanks for this huge contribution, and sorry, that it took me so long to respond.

I suspect the QuerySelector node adds redundant functionality: you can already retreive DOM data by an ID by creating an input IOBox and labelling it with "#id" (where you replace "id" with the actual id, obviously). Like described in the "Reading from the DOM" section of the VVVV.js Integration Guide.

Or maybe I missed something? Correct me if I'm wrong.

@noobusdeer
Copy link
Author

Yes, I use query selector to retrive information from dom elements, but I need to know from select element which is selected. I'm on holidays in spain so I can't answer fast)

On Tue, Aug 19, 2014 at 10:36 AM, Matthias Zauner
[email protected] wrote:

Thanks for this huge contribution, and sorry, that it took me so long to respond.
I suspect the QuerySelector node adds redundant functionality: you can already retreive DOM data by an ID by creating an input IOBox and labelling it with "#id" (where you replace "id" with the actual id, obviously). Like described in the "Reading from the DOM" section of the VVVV.js Integration Guide.

Or maybe I missed something? Correct me if I'm wrong.

Reply to this email directly or view it on GitHub:
#16 (comment)

Fix CDR remainder pin
@noobusdeer
Copy link
Author

Hi, im returned from holidays.
QuerySelector used for selectIndex from select with js.
I also have bugfix of my nodes in my fork so i can't understand how update my pull request.

@zauner
Copy link
Owner

zauner commented Sep 23, 2014

Hi, I was away from VVVV.js for a while, but back now :)

Ok, I'm pretty sure, QuerySelector does the same as named IOBoxes do, described in the VVVV.js Integration Guide. For example, you can get the selected option of a select box by naming an input IOBox like #select-box-id option:selected

So, if you can confirm that this accomplishes the same, I would suggest we drop the QuerySelector node, in order to avoid duplicate functionality.

As for the bugfix: I think it will be added automatically to the pull request, as soon as you push again to that branch. Probably this is what happened with the "fix CDR" commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants