flowey/gh: ensure the "all good" job does what its supposed to do (mi…

…crosoft#176)

It seems that on github, this job never actually did what it was
supposed to do, which was:

- pass if all previous jobs passed
- fail if any previous job failed

Instead, it seems that in the case of any previous job failing, GitHub
Actions would simply skip executing the "all good" job entirely, and
treat the skip as a "pass" of the (required) check. An interesting
default indeed...

We never noticed this as we would previously run the PrivateVsoBuild
job, which was a superset of all open-source checks, and would therefore
fail if any open-source check failed, causing the PR to be blocked even
through the "all good" check was ostensibly "passed".

This PR should fix things up such that our "all good" job does what its
supposed to do, by relying on a workaround suggested in
actions/runner#2566 (albeit, a slightly
tweaked variant of it).

* * * 

I also switched the job to run on a Linux machine, which I believe is
marginally faster to provision and execute on.

flowey/flowey_cli/src/pipeline_resolver/ado_yaml.rs

@@ -87,6 +87,8 @@ pub fn ado_yaml(
             arch,
             cond_param_idx,
             ref ado_pool,
+            gh_override_if: _,
+            gh_global_env: _,
             gh_pool: _,
             gh_permissions: _,
             ref external_read_vars,

flowey/flowey_cli/src/pipeline_resolver/direct_run.rs

@@ -93,6 +93,8 @@ fn direct_run_do_work(
             cond_param_idx,
             ado_pool: _,
             ado_variables: _,
+            gh_override_if: _,
+            gh_global_env: _,
             gh_pool: _,
             gh_permissions: _,
             ref external_read_vars,

flowey/flowey_cli/src/pipeline_resolver/generic.rs

@@ -66,6 +66,8 @@ pub struct ResolvedPipelineJob {
     pub arch: FlowArch,
     pub ado_pool: Option<AdoPool>,
     pub ado_variables: BTreeMap<String, String>,
+    pub gh_override_if: Option<String>,
+    pub gh_global_env: BTreeMap<String, String>,
     pub gh_pool: Option<GhRunner>,
     pub gh_permissions: BTreeMap<NodeHandle, BTreeMap<GhPermission, GhPermissionValue>>,
     pub external_read_vars: BTreeSet<String>,
@@ -166,6 +168,8 @@ pub fn resolve_pipeline(pipeline: Pipeline) -> anyhow::Result<ResolvedPipeline>
             cond_param_idx,
             ado_pool,
             ado_variables,
+            gh_override_if,
+            gh_global_env,
             gh_pool,
             gh_permissions,
         },
@@ -217,6 +221,8 @@ pub fn resolve_pipeline(pipeline: Pipeline) -> anyhow::Result<ResolvedPipeline>
             label,
             ado_pool,
             ado_variables,
+            gh_override_if,
+            gh_global_env,
             gh_pool,
             gh_permissions,
             platform,

flowey/flowey_cli/src/pipeline_resolver/github_yaml/github_yaml_defs.rs

@@ -268,6 +268,10 @@ pub struct Job {
     pub permissions: BTreeMap<Permissions, PermissionValue>,
     #[serde(skip_serializing_if = "Vec::is_empty")]
     pub needs: Vec<String>,
+    #[serde(rename = "if", skip_serializing_if = "Option::is_none")]
+    pub r#if: Option<String>,
+    #[serde(skip_serializing_if = "BTreeMap::is_empty")]
+    pub env: BTreeMap<String, String>,
     pub steps: Vec<serde_yaml::Value>,
 }
 

flowey/flowey_cli/src/pipeline_resolver/github_yaml/mod.rs

@@ -86,6 +86,8 @@ pub fn github_yaml(
             arch,
             ref external_read_vars,
             ado_pool: _,
+            ref gh_override_if,
+            ref gh_global_env,
             ref gh_pool,
             ref gh_permissions,
             cond_param_idx: _,
@@ -565,6 +567,8 @@ EOF
                         })
                         .collect()
                 },
+                r#if: gh_override_if.clone(),
+                env: gh_global_env.clone(),
                 steps: gh_steps,
             },
         );

flowey/flowey_cli/src/pipeline_resolver/viz.rs

@@ -75,6 +75,8 @@ fn viz_pipeline_generic(
             cond_param_idx: _,
             ref ado_pool,
             ado_variables: _,
+            gh_override_if: _,
+            gh_global_env: _,
             ref gh_pool,
             gh_permissions: _,
             ref external_read_vars,
@@ -253,6 +255,8 @@ pub fn viz_pipeline_dot(pipeline: ResolvedPipeline, _backend: FlowBackend) -> an
                 cond_param_idx: _,
                 ado_pool,
                 ado_variables: _,
+                gh_override_if: _,
+                gh_global_env: _,
                 gh_pool,
                 gh_permissions: _,
                 external_read_vars: _,