Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corresponding fix of tests for yuglify pull request #17 #97

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

leik
Copy link

@leik leik commented Aug 19, 2013

Corresponding fix of tests for yuglify pull request yui/yuglify#17.

@caridy
Copy link
Member

caridy commented Aug 20, 2013

Something is not right here. I see 3 files changes (all of them build results), which obviously breaks the tests.

✗ min should be same with UglifyJS 
        »   actual expected
        9ed47fda2818b46e9a3e8d6ef54ebb5f2aaa0aec4341cdfdbaec18edb1af80531133e61b3ff939be 

Are you missing anything as part of the PR?

@leik
Copy link
Author

leik commented Aug 20, 2013

This is corresponding to the PR yui/yuglify#17, which you need to merge in first before you get this tests fix in.

@leik
Copy link
Author

leik commented Aug 27, 2013

Can someone please have a look at the yui/yuglify#17, thank you!

@leik
Copy link
Author

leik commented Feb 26, 2014

yui/yuglify#17 has been updated, this is to fix the yuglify tests hosted in shifter. The build is expected to fail here until yui/yuglify#17 is merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants