This repository has been archived by the owner on Aug 26, 2020. It is now read-only.
Fix signature/deliveryId header fields to LC #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hubot doesn't seem to understand the case sensitive "X-Hub-Signature" or "X-Github-Delivery" header fields when listening to webhook events. Making them lowercase fixes this issue, of which you can then proceed to validate the sha1 hash to ensure that the event is coming from github.
made signature/deliveryId header fields lowercase
|
Another gentle bump :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hubot does not seem to like the case sensitive "X-Hub-Signature" or "X-Github-Delivery" header fields. Making them lowercase seems to fix the issue. This PR is in relation to #1.