This repository has been archived by the owner on Aug 26, 2020. It is now read-only.
Parse HUBOT_GITHUB_API, setting host, prefix and protocol. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By any chance, does this make it support GitHub Enterprise? I'll probably test the adapter with and without this PR to find out for myself eventually, but if folks happened to have tried it before and have any tips, that could save some time. |
|
OK, I was just able to successfully use the code in this PR with GitHub Enterprise by doing:
So 👍 from me! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set the
host,prefixandprotocolclient options via the ENV variableHUBOT_GITHUB_API. This conforms to the Hubot ecosystem Github client configuration API (e.g. hubot-deploy, github-merge, etc.).