Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support typst #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: support typst #54

wants to merge 3 commits into from

Conversation

b-yp
Copy link

@b-yp b-yp commented Oct 31, 2024

Hello, I just added support for typst in the plugin, and it seems to be working fine. However, I'm unsure if this PR can be merged, as it depends on too many files, and the files are not loaded using logseq.Experiments.loadScripts(). This is the only way I could do it; I can't find a better solution. If you have any other thoughts, please let me know.

20241031_100658.mp4

@xyhp915
Copy link
Owner

xyhp915 commented Nov 4, 2024

Hi @b-yp Just simplified the typst package. Feel free to continue any works if you want :)

@b-yp
Copy link
Author

b-yp commented Nov 4, 2024

Thank you @xyhp915 ! The code you optimized is fantastic; it eliminated a lot of JS file imports and switched to using npm imports. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants