Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat: move to v13 #1667

Open
wants to merge 248 commits into
base: master
Choose a base branch
from
Open

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Oct 18, 2024

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    features and refactor for AppV2

  • What is the current behavior? (You can also link to an open issue here)
    system incompatible with v13
    system uses Dialog (v1)
    system uses ItemSheet (v1)
    AdvancedSettings uses AppV1
    getChatLogEntryContext Hook no longer present in v13
    Actor Sheets use AppV1
    Consumables and Attachment list reset to default on update
    AP Values are only numbers
    Can't drag-drop AE's
    Dialog's still use jQuery
    Macro Compendium uses DialogV1
    ActorSheet items are sorted by a handlebar helper
    Can't drag-drop a folder
    Can enter non-unique skill names,
    No way to drag multiple items that aren't in one folder
    Only PSI and ALT characteristics can be hidden if zero

  • What is the new behavior (if this is a feature change)?
    system mostly runs with v13
    refactor to use DialogV2
    refactor to ItemSheetV2
    refactor AdvancedSettings to ApplicationV2
    refactor to TwodsixChatLog that extends core ChatLog and ChatPopout (not mixin?)
    Actor Sheets now use app v2
    Remove default for consumable lists and preserve state across refresh. All lists initialize to collapsed on first open.
    AP values may be formulas
    Limited ability to drag-drop Active Effects
    Move all JQuery references in Dialogs to DOM
    Move macros to DialogV2
    Actor sheet items are sorted in sheet _prepareContext()
    Allow ability to drag-drop item folders
    Try to make skill names unique by appending number if needed (this is so that skills proxy works correctly)
    Add @ItemList enricher to drag multiple items from items sidebar
    Allow EDU, SOC and INT characteristics to be hidden if zero.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    YES, data migration is one way and older chat message will not function.

  • Other information:

@marvin9257 marvin9257 changed the title DRAFT feat: move to v13 WIP feat: move to v13 Oct 18, 2024
note that page reference doesn't work
also fix issue where consumable parentName and parentType not clearing on drop
Not certain why this fix was necessary given code explicitly added earlier.
also fix tab format on traveller sheet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant