Support table and column rename operations preceding drop_multicolumn_constraint operations
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the physical table name when creating triggers. This ensures that if the table is renamed in-memory by a preceding operation, trigger creation still uses the correct table name.
When dropping the temporary column, use the physical table name instead of the logical table name. This ensures that if the table was renamed by a preceding operation, the correct table name is used.
When a column is renamed, update the column name in any constraints affecting the column in the in-memory schema. This ensures that subsequent operations can find the column in the constraint list by its expected name.
When duplicating columns to remove a constraint, use the name of the column as it will be when the migration is completed as the basis for its name under duplication.
Save the old column name for use as the physical column name in the down trigger.
kvch
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
drop_multicolumn_constraintoperations can be preceded by rename table and rename column operations as in the following example:{ "name": "24_drop_constraint", "operations": [ { "rename_table": { "from": "items", "to": "products" } }, { "rename_column": { "table": "products", "from": "name", "to": "item_name" } }, { "drop_multicolumn_constraint": { "table": "products", "name": "name_length", "up": { "item_name": "item_name" }, "down": { "item_name": "SELECT CASE WHEN length(item_name) <= 3 THEN LPAD(item_name, 4, '-') ELSE item_name END" } } } ] }Part of #239.