-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import and call the env analysis script #4
base: main
Are you sure you want to change the base?
Conversation
Will need more python tests, but this does include all the failure conditions in the end-to-end tests. We'll need to figure out how to automatically bump the failing envs, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I made you some work it seems 😄
envs/env1.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Move to a tests folder?
|
||
|
||
def is_preview(version): | ||
candidates = ["rc", "beta", "alpha"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
candidates = ["rc", "beta", "alpha"] | |
candidates = ("rc", "b", "a") |
I think PEP440 wants "a" and "b" for alpha and beta releases (not sure what rattler does of course)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rattler
doesn't do anything different, the versions are those on conda-forge
. I don't know if that always has the same rules as PyPI.
I haven't seen alpha/beta releases on conda-forge
, yet, though, so those are there for completeness. I'd also go with a set
literal instead of tuple
/list
literals.
Co-authored-by: Mathias Hauser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made you some work it seems
Fighting the actions syntax took longer than expected 😅
|
||
|
||
def is_preview(version): | ||
candidates = ["rc", "beta", "alpha"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rattler
doesn't do anything different, the versions are those on conda-forge
. I don't know if that always has the same rules as PyPI.
I haven't seen alpha/beta releases on conda-forge
, yet, though, so those are there for completeness. I'd also go with a set
literal instead of tuple
/list
literals.
(from pydata/xarray#9754)