Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scans #370

Merged
merged 39 commits into from
Jul 27, 2024
Merged

Add scans #370

merged 39 commits into from
Jul 27, 2024

Conversation

dcherian
Copy link
Collaborator

@dcherian dcherian commented Jun 28, 2024

xref #91, closes #251

  • Add Xarray interface
  • Add tests for binning

flox/aggregations.py Outdated Show resolved Hide resolved
@dcherian dcherian marked this pull request as ready for review July 27, 2024 03:21
@dcherian dcherian enabled auto-merge (squash) July 27, 2024 03:22
@dcherian
Copy link
Collaborator Author

Windows failure should get fixed upstream: ml31415/numpy-groupies#90

_____________________________ test_groupby_reduce _____________________________
[gw2] win32 -- Python 3.12.4 C:\Users\runneradmin\micromamba\envs\flox-tests\python.exe
tests\test_properties.py:85: in test_groupby_reduce
    array=npst.arrays(
tests\test_properties.py:133: in test_groupby_reduce
    assert_equal(expected, actual, tolerance)
C:\Users\runneradmin\micromamba\envs\flox-tests\Lib\contextlib.py:81: in inner
    return func(*args, **kwds)
E   AssertionError: 
E   Not equal to tolerance rtol=1e-07, atol=1e-15
E   
E   Mismatched elements: 1 / 1 (100%)
E   Max absolute difference among violations: 2.1474836e+09
E   Max relative difference among violations: 1.03019744e-07
E    ACTUAL: array([2.084536e+16], dtype=float32)
E    DESIRED: array([2.084536e+16], dtype=float32)
E   Falsifying example: test_groupby_reduce(
E       array=array([3.8751665e+16, 2.3784419e+16, 0.0000000e+00], dtype=float32),
E       dtype=dtype('=i1'),  # or any other generated value
E       func='mean',
E   )

@dcherian dcherian disabled auto-merge July 27, 2024 04:12
@dcherian dcherian merged commit 1c10b74 into main Jul 27, 2024
14 of 15 checks passed
@dcherian dcherian deleted the scans branch July 27, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants