Sidekiq Enterprise: until matcher #232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidekiq Enterprise use a unique_until option to specify when the uniqueness is allowed to go away. This matcher allows you to write specifications against a worker to validate those expectations.
|
Thanks @wizardofelves and @leviwilson for the original effort here. However, this doesn't need to wait for that - having it for Ent users of Sidekiq will be welcome on its own. |
wspurgin
reviewed
Feb 3, 2025
| MuhWorker | ||
| end | ||
|
|
||
| it { should be_unique.for(interval).until(:success) } |
There was a problem hiding this comment.
🎨 Can you add something akin to this and the other subject below as examples to the README? As well as specifying that SidekiqUniqueJobs is not yet supported for this matcher?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Sidekiq Enterprise's Unique Jobs feature, you have the ability to specify an unlock policy.
This PR adds an until matcher so that you may specify an expectation against a worker for it like so:
It also will fail that it is not supported if a user tries to use it with SidekiqUniqueJobs.
(all credit to @leviwilson for his work on this, I just rebased and brought it current)