Add LED patterns to LED documentation #2774
Conversation
| :language: c++ | ||
| :lines: 15-20 | ||
| :linenos: | ||
| :lineno-start: 15 | ||
|
|
||
| .. image:: images/rainbow.gif |
There was a problem hiding this comment.
I wonder if specifying the :width: will fix the pdf error
There was a problem hiding this comment.
🤔 Hmm. I'll need to test that. I don't have LaTeX tools installed locally so it'll need to be on CI, which could be frustrating.
The style guide does explicitly call out gifs as being unacceptable for storage and accessibility concerns, but I don't see a way around it since the whole point of these docs are to demonstrate animations
Include screenshots/screen recordings of all examples Examples mostly use the same discontinuous gradient for consistency and to make reversed and scrolling effects obvious
Should be 0.25 Hz, not 4 Hz
Move progress mask example to the mask example
|
this should remove the ignore from inspector.json |
Frustratingly, the :poster: attribute won't use transformed asset paths
|
Setting the width to 900 on the videos makes mobile scroll. Looks like the images get scaled down |
|
If you put in a static png with the same name as the video files, I think that will fix the pdf build |
As in, |
|
|
yes. That will work for image files, but I'm not sure if sphinx will automatically fall back from a video file to an image file |
Already covered in the buffer view section
This won't work, looks like ..only would probably be best. |
|
On chrome and edge, the videos don't show a play. Maybe because they are not tall enough? Works ok on Firefox
|
|
I'm not sure, both firefox and chrome showed the controls overlaid on the videos in my testing. Annoyingly, the controls obscure the videos, and there doesn't seem to be any options for moving the (eg to be below the video). Maybe we could have some custom JS to make the controls appear on hover? https://stackoverflow.com/q/40284816 |
|
The video controls are there. The slider is the progress slider. If you click on the very very top few pixels of the video and press space, it will start to play and the controls will fade away. Since this is looping, I would rather put in gifs for the website and png for the pdf. |
That was my preference too, but Daltz says it's an accessibility concern to have autoplaying gifs |
|
I guess the fix then is making the videos a lot taller so the controls render properly |
We might be able to do something like this, rather then make new videos: https://stackoverflow.com/a/65116261 |
Videos are paused by default This avoids the issue of the controls overlapping and obscuring the animations
Render gifs everywhere else (PDFs should render just the first frame)
|
A bit of feedback from our beta testing: LEDPattern examples sometimes refer to calling a function using the Units library, like Updating the example to include the Units reference before |
|
this has conflicts now since some of the css was merged in the a-stop PR |
|
\inspector fix all |
Inspector ReportUp To DateOutdated - Automatically FixedInvalid - Manual Intervention Needed |
Resolves #2773