Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PID Video #2631

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PID Video #2631

wants to merge 3 commits into from

Conversation

horner
Copy link
Contributor

@horner horner commented Apr 5, 2024

Notes from prior PR:
#2609

Remove trailing space.
------------------

* https://file.tavsys.net/control/controls-engineering-in-frc.pdf - See section 2 and section 6.
* `VIDEO: What Is Feedforward Control? | Control Systems in Practice <https://www.youtube.com/watch?v=FW_ay7K4jPE>`_
Copy link
Member

@calcmogul calcmogul Apr 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 15-minute video's explanation of feedforward is good, but the middle third brings up frequency domain stuff that isn't relevant to FRC students (they use modern controls for basically everything, whether they know it or not), and the last third presents a Simulink example that isn't reproducible by FRC students, cuz MATLAB costs money. frc-docs already has some JS tutorials for feedforward and feedback.

Other Information
------------------

* https://file.tavsys.net/control/controls-engineering-in-frc.pdf - See section 2 and section 6.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct references would be chapter 2 "PID controllers" and section 7.8 "Feedforward"; in a.b.c.d, a is chapter, b is section, c is subsection, and d is subsubsection.

By the way, this page is already a verbatim copy of chapter 2.

@gerth2
Copy link
Contributor

gerth2 commented Oct 9, 2024

super late to the party but since I was in here looking for controls-related PR's anyway....

What I do think the video brings up is the notion that an FRC-focused pedagogy is the best way to move forward for this competition. While I personally found the video useful, the jump to other tools and laplace domain is going to be a jarring experience for the person who just learned PID fifteen minutes ago.

Core elements I think are useful to a pedagogy in future doc changes:

  1. Time-domain focus - Not assuming other domains will be tractable by the average high schooler.
  2. Specific examples tied to motors and motor-driven things - this is all an FRC student knows (and mostly all they'll ever need to know about)
  3. Consistent application vocabulary (docs are solid on this currently, but caution is needed with external resources that refer to the same thing with different words)
  4. Scaffolding by desired outcomes - 99% of students start down the controls path because they're asked to achieve some behavior on a robot. Good flow will involve trying to get them to build up to that behavior, recognize their success, and look to the future to see what else is possible. Critically though... not by skipping steps, and not by discarding ideas simply because they're "simple" or "non-optimal".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants