Rename advanced-controls to controls #2532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really don't mind calling them advanced controls, but since it is already under an "Advanced Programming" section calling it advanced controls implies there is a "basic" controls. This is just "controls" and yes it is "advanced" for the average team. So I am good with the change. This does touch a bunch of files so I think we should have multiple reviews. |
|
We generally don't like to move things around in-season. While the redirects make it so that links aren't broken, there's still people's muscle memory as well as merge issues with PRs |
|
I am personally fine with letting it sit here until after the season is over, I just like to PR things in the moment before I forget. |
jasondaming
added
the
Waiting On: Dependency
|
There's conflicts to resolve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling it "advanced" scares people away from its contents, even though the docs that could make them more understandable are under the "advanced" section.