Add info on how DS/NetComm safety controls work #2302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sciencewhiz
reviewed
Jul 29, 2023
| Placeholder for Safety Writeup | ||
| ============================== | ||
|
|
||
| .. Note:: From a Chief Delphi `thread reply <https://www.chiefdelphi.com/t/severe-100-packet-loss/428031/139?u=peter_johnson/>`_ by WPILib Developer Peter Johnson. |
There was a problem hiding this comment.
This should be in the PR description/commit message, but doesn't need to be in the article
|
|
||
| - CTRE uses a custom approach that reads the disable indicator on NetComm and stops motors within 100 `ms` of a disable. | ||
|
|
||
| Potential Improvements: |
There was a problem hiding this comment.
I would delete this section as it isn't really useful to teams in understanding how the current system works
| @@ -131,6 +137,9 @@ FRC Glossary | |||
| pose | |||
| The collection of position and rotation information that describes how a rigid body is oriented in space, relative to some fixed reference point. | |||
|
|
|||
| PWM | |||
There was a problem hiding this comment.
I would link to the FRC docs pages rather then wikipedia
|
Is this supposed to have the DS picture updates, or is that intended for another PR? |
Different PR; mistake on my part, will update. |
|
PR is connected to the wrong branch; closing and opening a new draft PR to continue discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2227.