Add docs on profiling with VisualVM #2251
Conversation
|
I should probably detail not just memory usage, but function timing |
|
@sciencewhiz done, if you can review |
source/docs/software/advanced-gradlerio/profiling-with-visualvm.rst
Outdated
Show resolved
Hide resolved
source/docs/software/advanced-gradlerio/profiling-with-visualvm.rst
Outdated
Show resolved
Hide resolved
source/docs/software/advanced-gradlerio/profiling-with-visualvm.rst
Outdated
Show resolved
Hide resolved
| jvmArgs.add("-Dcom.sun.management.jmxremote.local.only=false") | ||
| jvmArgs.add("-Dcom.sun.management.jmxremote.ssl=false") | ||
| jvmArgs.add("-Dcom.sun.management.jmxremote.authenticate=false") | ||
| jvmArgs.add("-Djava.rmi.server.hostname=10.XX.XX.2") // Replace XX.XX with team number |
There was a problem hiding this comment.
Does it work with mDNS? If so, that would avoid the needing to specify different IPs for different networking configs.
There was a problem hiding this comment.
Unsure, pending testing.
source/docs/software/advanced-gradlerio/profiling-with-visualvm.rst
Outdated
Show resolved
Hide resolved
| @@ -11,3 +11,4 @@ GradleRIO is the mechanism that powers the deployment of robot code to the roboR | |||
| code-formatting | |||
| gradlew-tasks | |||
| deploy-git-data | |||
| profiling-with-visualvm | |||
There was a problem hiding this comment.
I'm not sure that advanced-gradlerio is the place for this. It does require modifying build.gradle. There isn't a great place that already exists, maybe telemetry?
There was a problem hiding this comment.
I'd rather not place it in telemetry, as I don't think we typically want to recommend users modify their build.gradle. If this is something common, we could enable it by default?
There was a problem hiding this comment.
I agree with @Daltz333 that users should only be enabling this for diagnosis and shouldn't be in the build.gradle deployed for matches. I think that Software Tools might not be a bad place for this, but not Telemetry for the same reason as Daltz said.
There was a problem hiding this comment.
I don't think I explained my concern with putting it in the advanced gradlerio section correctly. The other things in that section are permanent items that a team wants to change the build process. This is a temporary item to help with debugging. Because of that, I think it belongs elsewhere.
| :alt: Viewing a dump in VisualVM | ||
| :width: 700 | ||
|
|
||
| Clicking on :guilabel:`Summary` and selecting :guilabel:`Objects` instead will show a breakdown of objects by quantity. The below screenshot showcases a completely empty robot program, and then one that creates an million large ``ArrayList`` of integers. |
There was a problem hiding this comment.
Is there a way to see where those million integers is created? I'm not sure there's much useful for teams based on what's shown in the screenshot.
There was a problem hiding this comment.
Hm, I'll have to find that out myself
There was a problem hiding this comment.
In dotMemory, it shows the creation call stack, I wonder if VisualVM has something similar.
source/docs/software/advanced-gradlerio/profiling-with-visualvm.rst
Outdated
Show resolved
Hide resolved
…m.rst Co-authored-by: Starlight220 <[email protected]>
|
This seems like something it would be great to merge before the season starts. Is there more left to do? |
sciencewhiz
force-pushed
the
visualvm
branch
from
3d4da73 to
7627ce1
Compare
Fixes #2229