KOP Item resources #151

benjamin-antupit · 2019-07-23T14:15:31Z

Copied from #25.

I would appreciate any thoughts on @firecrafty's original questions:

Feedback on how to organize this/where to put things would be great, I thought putting them in their own large section would be the right move but I'm not sure anymore as I don't want the sidebar to get too cluttered.

Edit: I'll be away from the internet for two weeks (back on August 11th) and I plan to continue working on this PR when I return.

source/docs/hardware/kop-item-resources/control/vmx-pi.rst

source/docs/hardware/kop-item-resources/index.rst

source/docs/hardware/kop-item-resources/mechanical/linear-bushings.rst

benjamin-antupit · 2019-07-24T02:39:24Z

@Daltz333 Should kop-item-resources move from docs/hardware/kop-item-resources to docs/kop-item-resources?

Daltz333 · 2019-07-24T03:49:16Z

Definitely keep it in hardware

benjamin-antupit · 2019-07-27T20:01:52Z

Can someone help me figure out why the build is failing? Is it an Azure thing or something to do with this PR?

Daltz333 · 2019-07-28T04:00:35Z

Some mathematical symbol that is included that the PDF generation doesn't like. Try to use the UTF versions of symbols and minimize latex usage

AustinShalit

The links should be updated to use HTTPS.

@Daltz333 Do you have any ideas about how to make this page look cleaner. Right now I feel like there is a wall of links where on ScreenSteps the download links stood out.

For comparison: https://wpilib.screenstepslive.com/s/currentCS/m/kop/l/696729-multisim-ultiboard-and-statechart-module

AustinShalit · 2019-07-28T18:09:00Z

(This page is the Multisim page, not the whole PR)

Daltz333 · 2019-07-28T19:25:14Z

The Kop should be a section under hardware. Adding each individual (hardware related) section to the main toc makes the sidebar substantially longer with little gain. Looking at things further, I see no need to even call it "Kit of Parts" (this will still make the sidebar longer, but with a benefit at least). My thoughts are, with your current organization scheme, that things can then be added to each section. (motors to motors).

source/docs/hardware/kop-item-resources/software/multisim-ultiboard-and-statechart-module.rst

Daltz333

Absolutely fantastic! As always thank you for your work!

This is quite a huge change so will likely take several rounds of revisions. I love the structure and use the download directives.

source/docs/hardware/control/vmx-pi.rst

source/docs/hardware/mechanical/linear-bushings.rst

source/docs/hardware/motors/bosch-seat-motor.rst

source/docs/hardware/motors/nidec-dynamo-bldc.rst

source/docs/hardware/sensors/jetson-tx1-developer-kit.rst

source/docs/hardware/sensors/mb1013-hrlv-maxsonar-ez-ultrasonic-sensor.rst

Daltz333

Remove the .DS_Store file

benjamin-antupit · 2019-08-24T14:00:50Z

@Daltz333 Anything else?

benjamin-antupit · 2019-08-31T18:40:44Z

@AustinShalit Please review.

Daltz333

Thanks for the work :)

source/docs/hardware/sensors/mb1013-hrlv-maxsonar-ez-ultrasonic-sensor.rst

source/docs/hardware/control/vmx-pi.rst

source/docs/hardware/mechanical/linear-bushings.rst

AustinShalit · 2019-09-03T20:10:25Z

@Daltz333 How do you feel about moving the content located inside of the zip files out of the zip files?

Daltz333 · 2019-09-08T14:17:39Z

We're getting those zip files moved to other locations, and then this should be ready for merge.

benjamin-antupit · 2019-09-12T23:24:52Z

Can someone rebuild this PR?

Daltz333 · 2019-09-13T02:30:39Z

The pull-request failing is accurate, kauai-kabs with the sub-domain vmx-pi no longer exists (the http version will redirect, and the https will fail with an invalid certification error).

Daltz333

Links need to be fixed, and then the zip files need to reference https://first.wpi.edu/FRC/roborio/Docs/ instead of being local.

Daltz333

This is just a partial review of the links that needs fixing. There are still more.

source/docs/hardware/control/vmx-pi.rst

source/docs/hardware/mechanical/linear-bushings.rst

Daltz333 · 2019-09-14T14:29:03Z

The kauai labs webpage keeps going offline. I'll be contacting them about this. However, I don't see any issues with the links any more. @AustinShalit would you mind retriggering this build?

Daltz333 · 2019-09-14T14:53:43Z

It seems to have succeeded. Would you mind fixing the last couple of redirects?

benjamin-antupit · 2019-09-14T15:20:55Z

I think I fixed all the redirects and added links to https://first.wpi.edu/FRC/roborio/Docs/ where applicable. Could you also upload L4TMultimediaAPIReference.zip to https://first.wpi.edu/FRC/roborio/Docs/? It belongs in docs/hardware/sensors/jetson-tx1-developer-kit.rst line 65.

Daltz333 · 2019-09-14T15:22:06Z

Was that link previously hosted on ScreenSteps as well?

benjamin-antupit · 2019-09-14T15:35:43Z

The file was linked on NVIDIA's website. The link label is "Multimedia Guide" and you can find it under the Documentation heading on ScreenSteps.

benjamin-antupit · 2019-10-05T16:19:01Z

I was just reviewing the changes this PR makes to the navigation sidebar. Would it be better to move all the Kit of Parts resources to one super-folder which has an index for all the KOP sub-categories (Sensors from the KOP, Control, Mechanical, Motors, Pneumatics, Robot Quick Build, Wiring & Connections and Other) to avoid adding too much to the navigation bar?

Daltz333 · 2019-10-06T15:45:30Z

@yellowjaguar5 now with the revision, I agree.

source/docs/hardware/robot-quick-build/robot-quick-build-overview.rst

source/index.rst

source/docs/hardware/kit-of-parts/control/vmx-pi.rst

benjamin-antupit · 2019-10-20T04:49:53Z

One of the LintCheck builds failed, but not the other one. Huh.

modelmat · 2019-10-29T20:01:26Z

Is this all fine to merge then?

Will probably have merge conflicts though.

benjamin-antupit · 2019-10-30T02:51:40Z

I want to add source files for the illustrations I created per @Daltz333's comment in #200 and then I think it will be mergeable.
It would be great if this PR could get a review, though.

Kevin-OConnor · 2019-10-30T13:26:19Z

We are planning on adding a lot more KoP content this season and the people doing it are more comfortable doing so in Screensteps than in RTD so our current plan is to leave all KoP content on Screensteps for this season.

Daltz333 · 2020-03-20T02:26:41Z

@yellowjaguar5 Mind updating this for the current season?

benjamin-antupit · 2020-03-20T02:28:44Z

Sure, but before I put too many hours into it, I want to make sure FIRST is ready to move this content to WPILib docs. @Kevin-OConnor, is that correct? If so, I have time this weekend to start (and hopefully finish) it.

benjamin-antupit · 2020-04-12T20:26:06Z

This page on ScreenSteps Live has 4 downloadable files linked. Should I include the files themselves under kit-of-parts/motors/files and add download links or link to the ScreenSteps Live download links?

Daltz333 · 2020-04-12T22:07:51Z

The files are now located at https://first.wpi.edu/FRC/roborio/Docs/ with each of their original file names. EG: https://first.wpi.edu/FRC/roborio/Docs/2020-02-12_JE-PLG-149_R2.pdf

benjamin-antupit · 2020-04-14T16:53:16Z

I added the page for the Johnson Electric PLG Motor. As far as I can tell, nothing else was added to ScreenSteps KOP Documentation this season. Is that correct?

benjamin-antupit · 2020-04-25T21:03:15Z

@Daltz333 Could you review this?

Daltz333 · 2020-04-25T21:04:11Z

It looks fine as far as I can tell. However @Kevin-OConnor needs to do a review.

Co-authored by: daltz333 <[email protected]>

Daltz333 · 2021-10-27T16:03:34Z

This is still planned, but there are some hurdles that need to get done on the FIRST side of things.

Daltz333 requested changes Jul 24, 2019

View reviewed changes

benjamin-antupit changed the title ~~[WIP] KOP Item resources~~ KOP Item resources Jul 28, 2019

AustinShalit requested changes Jul 28, 2019

View reviewed changes

Daltz333 reviewed Jul 28, 2019

View reviewed changes

source/docs/hardware/kop-item-resources/software/multisim-ultiboard-and-statechart-module.rst Outdated Show resolved Hide resolved

source/docs/hardware/kop-item-resources/software/multisim-ultiboard-and-statechart-module.rst Outdated Show resolved Hide resolved

Daltz333 requested changes Aug 19, 2019

View reviewed changes

Daltz333 requested changes Aug 21, 2019

View reviewed changes

Daltz333 previously approved these changes Sep 3, 2019

View reviewed changes

AustinShalit requested changes Sep 3, 2019

View reviewed changes

benjamin-antupit dismissed stale reviews from Daltz333 via 48669e8 September 3, 2019 16:46

benjamin-antupit requested a review from Daltz333 September 7, 2019 22:41

Daltz333 requested changes Sep 13, 2019

View reviewed changes

benjamin-antupit dismissed Daltz333’s stale review via 8bdaca9 October 5, 2019 16:07

Daltz333 added the Type: New Article label Oct 6, 2019

AustinShalit added the Blocked label Oct 6, 2019

AustinShalit removed the Blocked label Oct 6, 2019

benjamin-antupit requested review from Daltz333 and AustinShalit October 6, 2019 21:21

Daltz333 requested changes Oct 11, 2019

View reviewed changes

source/docs/hardware/robot-quick-build/robot-quick-build-overview.rst Outdated Show resolved Hide resolved

source/index.rst Show resolved Hide resolved

source/docs/hardware/kit-of-parts/control/vmx-pi.rst Outdated Show resolved Hide resolved

benjamin-antupit requested a review from Daltz333 April 14, 2020 21:47

Daltz333 force-pushed the kop-resources branch 2 times, most recently from 76bd8b2 to 0cc20be Compare September 7, 2020 16:52

Add KOP Resources Articles

1148505

Co-authored by: daltz333 <[email protected]>

Daltz333 force-pushed the kop-resources branch from 0cc20be to 1148505 Compare September 7, 2020 16:58

Daltz333 and others added 4 commits September 7, 2020 13:02

Fix rebase barf

2a11ce8

Remove nonexisting document references

e48ef5c

Update Invalid Links

1ffcf73

Reduce image sizes

c86dacc

KOP Item resources #151

Are you sure you want to change the base?

KOP Item resources #151

Conversation

benjamin-antupit commented Jul 23, 2019 • edited Loading

benjamin-antupit commented Jul 24, 2019

Daltz333 commented Jul 24, 2019

benjamin-antupit commented Jul 27, 2019

Daltz333 commented Jul 28, 2019

AustinShalit left a comment

Choose a reason for hiding this comment

AustinShalit commented Jul 28, 2019

Daltz333 commented Jul 28, 2019 • edited Loading

Daltz333 left a comment

Choose a reason for hiding this comment

Daltz333 left a comment

Choose a reason for hiding this comment

benjamin-antupit commented Aug 24, 2019

benjamin-antupit commented Aug 31, 2019

Daltz333 left a comment

Choose a reason for hiding this comment

AustinShalit commented Sep 3, 2019

Daltz333 commented Sep 8, 2019

benjamin-antupit commented Sep 12, 2019

Daltz333 commented Sep 13, 2019

Daltz333 left a comment

Choose a reason for hiding this comment

Daltz333 left a comment

Choose a reason for hiding this comment

Daltz333 commented Sep 14, 2019 • edited Loading

Daltz333 commented Sep 14, 2019

benjamin-antupit commented Sep 14, 2019

Daltz333 commented Sep 14, 2019

benjamin-antupit commented Sep 14, 2019

benjamin-antupit commented Oct 5, 2019 • edited Loading

Daltz333 commented Oct 6, 2019

benjamin-antupit commented Oct 20, 2019

modelmat commented Oct 29, 2019 • edited Loading

benjamin-antupit commented Oct 30, 2019

Kevin-OConnor commented Oct 30, 2019

Daltz333 commented Mar 20, 2020

benjamin-antupit commented Mar 20, 2020

benjamin-antupit commented Apr 12, 2020

Daltz333 commented Apr 12, 2020

benjamin-antupit commented Apr 14, 2020

benjamin-antupit commented Apr 25, 2020

Daltz333 commented Apr 25, 2020

Daltz333 commented Oct 27, 2021 • edited Loading

benjamin-antupit commented Jul 23, 2019 •

edited

Loading

Daltz333 commented Jul 28, 2019 •

edited

Loading

Daltz333 commented Sep 14, 2019 •

edited

Loading

benjamin-antupit commented Oct 5, 2019 •

edited

Loading

modelmat commented Oct 29, 2019 •

edited

Loading

Daltz333 commented Oct 27, 2021 •

edited

Loading