Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation is broken on duplicated articles #1318

Open
TheTripleV opened this issue Apr 10, 2021 · 3 comments
Open

Navigation is broken on duplicated articles #1318

TheTripleV opened this issue Apr 10, 2021 · 3 comments
Labels
bug Something isn't working Waiting On: Dependency Waiting on something from a dependency

Comments

@TheTripleV
Copy link
Member

From discord:

If you go to frc-docs and navigate to Glass / Plots, your sidebar will actually go to Robot Simulation / Plots

But, the Previous and Next buttons will happen in the scope of the glass location, not the robot simulation location

If you click next on that page, it will jump from robot simulation up to labview

Relevant Sphinx issue:
sphinx-doc/sphinx#9076
@Daltz333 Daltz333 added bug Something isn't working Waiting On: Dependency Waiting on something from a dependency labels Apr 10, 2021
@Daltz333
Copy link
Member

Daltz333 commented Apr 10, 2021 •
edited
Loading

Solutions:
a. Don't use duplicate entries (no)
or
b. Write an extension that overrides TOC and "copies" a duplicated article

  • This sounds quite painful and difficult to maintain

c. Wait for upstream

  • Likely the answer here.

@jasondaming
Copy link
Member

Wasn't this working before? Did something change? Yeah seems like something that upstream should fix?

@Daltz333
Copy link
Member

Daltz333 commented Apr 10, 2021 •
edited
Loading

No, this was never working. None of us looked at the sidebar 😄

@Daltz333 Daltz333 mentioned this issue Apr 10, 2021
Closed
sciencewhiz added a commit to sciencewhiz/frc-docs that referenced this issue Sep 29, 2021
@sciencewhiz
Remove incorrect reference to next article.
4a7d1df 
Next article isn't imaging due to wpilibsuite#1318. Imaging article is already
linked so no issue removing reference to next article
sciencewhiz added a commit to sciencewhiz/frc-docs that referenced this issue Sep 29, 2021
@sciencewhiz
Remove incorrect reference to next article.
9654a5b 
Next article isn't imaging due to wpilibsuite#1318. Imaging article is already
linked so no issue removing reference to next article
@sciencewhiz sciencewhiz mentioned this issue Sep 29, 2021
Merged
@Daltz333 Daltz333 mentioned this issue Apr 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Waiting On: Dependency Waiting on something from a dependency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Daltz333 @TheTripleV @jasondaming