Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpimath] ElevatorFeedforward calculate() deprecation is not documented #7736

Open
DeltaDizzy opened this issue Jan 27, 2025 · 0 comments · May be fixed by #7738
Open

[wpimath] ElevatorFeedforward calculate() deprecation is not documented #7736

DeltaDizzy opened this issue Jan 27, 2025 · 0 comments · May be fixed by #7738
Labels
type: bug Something isn't working.

Comments

@DeltaDizzy
Copy link
Contributor

Starting in 2025, the calculate(double velocity, double acceleration) method on ElevatorFeedforward has been deprecated for removal, but no guidance on what to change to was provided in the Javadocs. The replacement is the (currentVelocity, nextVelocity) overload, which should be mentioned. C++ may also need to be checked.
@DeltaDizzy DeltaDizzy added the type: bug Something isn't working. label Jan 27, 2025
@DeltaDizzy DeltaDizzy mentioned this issue Jan 27, 2025
Open
calcmogul added a commit to calcmogul/allwpilib that referenced this issue Jan 27, 2025
@calcmogul
[wpimath] Add deprecation message to ElevatorFeedforward
f3809c9 
C++ already has one.

Fixes wpilibsuite#7736.
@calcmogul calcmogul mentioned this issue Jan 27, 2025
Closed
sciencewhiz added a commit to Beachbot330/allwpilib that referenced this issue Jan 27, 2025
@sciencewhiz
Add checkstyle check for deprecation
9c5a041 
Ensures java deprecated notation is paired with javadoc and vice versa.
Adds javadoc deprecation for MecanumControllerCommand, ArmFeedForward,
ElevatorFeedforward, and MecanumDriveMotorVoltages
Fixes wpilibsuite#7736
Supersedes wpilibsuite#7737
@sciencewhiz sciencewhiz linked a pull request Jan 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working.
Projects
None yet
Milestone
No milestone
1 participant
@DeltaDizzy