Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/261: Prevent "Sync with Square" from unchecking in Firefox #266

Draft
wants to merge 10 commits into
base: trunk
Choose a base branch
from

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Jan 11, 2025

All Submissions:

  • Does your code follow the WooCommerce Sniffs variant of WordPress coding standards?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Will this change require new documentation or changes to existing documentation?

Changes proposed in this Pull Request:

This PR fixes the "Sync with Square" from being automatically unchecked on page load in the Firefox browser.

Closes #261

Steps to test the changes in this Pull Request:

Please follow the steps from the issue.

Changelog entry

Fix - Prevent "Sync with Square" from unchecking in the Firefox browser.

@Sidsector9 Sidsector9 requested a review from dkotter January 11, 2025 10:16
@Sidsector9 Sidsector9 changed the title fix/261: Prevent "Sync with Square" from unchecking on Firefox fix/261: Prevent "Sync with Square" from unchecking in Firefox Jan 11, 2025
@Sidsector9 Sidsector9 self-assigned this Jan 11, 2025
@dkotter dkotter added the needs: UAT The Issue/PR needs to go through UAT label Jan 13, 2025
@dkotter
Copy link
Contributor

dkotter commented Jan 13, 2025

This can go to UAT once QA passes

@qasumitbagthariya
Copy link
Contributor

QA Update ❌


@Sidsector9

I verified on my end, and I still see the brackets getting added when ticking and unticking the sync checkmark on both Firefox and Chrome browsers.

Screen.Recording.2025-01-14.at.2.20.27.AM.mov

@jeffpaul jeffpaul added this to the Future Release milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: UAT The Issue/PR needs to go through UAT status: e2e tests passing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review wc-square-admin-products.js logic
4 participants