-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/261: Prevent "Sync with Square" from unchecking in Firefox #266
Draft
Sidsector9
wants to merge
10
commits into
trunk
Choose a base branch
from
fix/261
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: e2e tests passing
and removed
status: e2e tests passing
labels
Jan 11, 2025
Sidsector9
changed the title
fix/261: Prevent "Sync with Square" from unchecking on Firefox
fix/261: Prevent "Sync with Square" from unchecking in Firefox
Jan 11, 2025
github-actions
bot
added
status: e2e tests passing
and removed
status: e2e tests passing
labels
Jan 11, 2025
dkotter
approved these changes
Jan 13, 2025
This can go to UAT once QA passes |
QA Update ❌I verified on my end, and I still see the brackets getting added when ticking and unticking the sync checkmark on both Firefox and Chrome browsers. Screen.Recording.2025-01-14.at.2.20.27.AM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
This PR fixes the "Sync with Square" from being automatically unchecked on page load in the Firefox browser.
Closes #261
Steps to test the changes in this Pull Request:
Please follow the steps from the issue.
Changelog entry