Review wc-square-admin-products.js logic

[kaushikasomaiya]

While testing another issue on my localhost WP site, I noticed the wc-square-admin-products.js is buggy.

On a variable product, once sync is enabled and I reload the page, the script marks the sync checkbox unchecked because it checks for if ( isVariable() && ! $( 'input[id^="variable_sku"]' ).length ) { too early.

This is a bit intermittent too. On Firefox, I am able to replicate it almost everytime on my site as well as the merchant's site.

[kaushikasomaiya]

@vikrampm1 @jeffpaul Can we increase the priority, please? It seems to be actually affecting the sync status.

• Create a variable product, mark it to sync with Square
• Reload the variable product edit page, it unticks the sync checkbox
• Saving it reflects the change. An admin / store manager could be unaware of this, and might end up disabling the sync when all they did is just tweaked the product description for example

[kaushikasomaiya]

@iamdharmesh Since you're looking into this, the other issue is brackets keep getting added when you tick and untick the sync checkmark.

I'll also check if I can come up with definite steps to replicate the sync checkmark issue as right now I can only replicate it on Firefox.