Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit origin address controls #13347

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Jan 18, 2025

Part of: #12439

Description

This PR adds the basic UI to the Edit origin address screen. In this PR, I included the styles input fields, dropdown, and expandable control. The changes submitted here are UI-focused only. In the next PR, I will work on managing the control state and the field validation.

Testing information

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Expand the shipment details section
  4. Expand on the origin address selection (3 dots)
  5. Tap on the pencil
  6. Check that the UI navigates to the edit origin address screen
  7. Check that the screen design is the expected
  8. Check that tapping on add company expands the company field

The tests that have been performed

Check that the UI works as expected

Images/gif

Screen_recording_20250118_145037.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jan 18, 2025
@atorresveiga atorresveiga added this to the 21.5 milestone Jan 18, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 18, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commiteb956fa
Direct Downloadwoocommerce-wear-prototype-build-pr13347-eb956fa.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commiteb956fa
Direct Downloadwoocommerce-prototype-build-pr13347-eb956fa.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.14%. Comparing base (7c04b28) to head (eb956fa).

Files with missing lines Patch % Lines
...ess/origin/WooShippingEditOriginAddressFragment.kt 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13347      +/-   ##
============================================
- Coverage     41.14%   41.14%   -0.01%     
  Complexity     6431     6431              
============================================
  Files          1322     1322              
  Lines         77207    77211       +4     
  Branches      10657    10658       +1     
============================================
  Hits          31765    31765              
- Misses        42617    42621       +4     
  Partials       2825     2825              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants