Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Track POS-specific analytics events in reader connection flow #13342

Open
wants to merge 8 commits into
base: woo-pos-update-payment-canceled-analytics-event
Choose a base branch
from

Conversation

samiuelson
Copy link
Collaborator

@samiuelson samiuelson commented Jan 17, 2025

Closes: #13301

Description

This PR modifies analytics tracking code to use a POS-specific prefix (woocommerce_android_pos) in the reader connection flow.

Steps to reproduce

The goal is to verify that during reader connection flow the events we track in IPP start with woocommerce_android_, and the ones in POS with woocommerce_android_pos_ prefix.

Testing information

  • Verify that reader connection events in IPP are tracked without any change
  • Verify that reader connection events in POS are tracked with a desired prefix

The tests that have been performed

I tested the card reader connection flows in POS and IPP modes and verified analytics events are tracked with proper prefixes, woocommerce_android_pos_ and woocommerce_android_ respectively.

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit230b8d6
Direct Downloadwoocommerce-wear-prototype-build-pr13342-230b8d6.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 17, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit230b8d6
Direct Downloadwoocommerce-prototype-build-pr13342-230b8d6.apk

@samiuelson samiuelson added this to the 21.5 milestone Jan 17, 2025
@samiuelson samiuelson marked this pull request as ready for review January 17, 2025 16:58
@samiuelson samiuelson changed the title 13301 woo pos update analytics events in reader connection flow [Woo POS] Track POS-specific analytics events in reader connection flow Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants