Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit origin address navigation #13338

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

atorresveiga
Copy link
Contributor

@atorresveiga atorresveiga commented Jan 16, 2025

Part of: #12439

Description

This PR adds the necessary changes to navigate from the origin order selection to the edit origin order fragment. The PR focuses only on the navigation part; in the next PR, I will work on the edit origin order fragment UI, the address validation, and returning the edited address to the main flow.

Testing information

  1. Open the orders tab
  2. Tap on an order eligible for shipping label creation
  3. Expand the shipment details section
  4. Expand on the origin address selection (3 dots)
  5. Tap on the pencil
  6. Check that the UI navigates to the edit origin address screen

The tests that have been performed

Checking that the navigation works as expected

Images/gif

Screen_recording_20250116_194509.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@atorresveiga atorresveiga added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Jan 16, 2025
@atorresveiga atorresveiga added this to the 21.5 milestone Jan 16, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitc7342ce
Direct Downloadwoocommerce-wear-prototype-build-pr13338-c7342ce.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitc7342ce
Direct Downloadwoocommerce-prototype-build-pr13338-c7342ce.apk

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 41.07%. Comparing base (9818b66) to head (c7342ce).
Report is 4 commits behind head on trunk.

Files with missing lines Patch % Lines
...ess/origin/WooShippingEditOriginAddressFragment.kt 0.00% 7 Missing ⚠️
...hippinglabels/WooShippingLabelCreationViewModel.kt 0.00% 3 Missing ⚠️
...orders/wooshippinglabels/address/AddressSection.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13338      +/-   ##
============================================
- Coverage     41.08%   41.07%   -0.01%     
- Complexity     6416     6417       +1     
============================================
  Files          1320     1321       +1     
  Lines         77211    77221      +10     
  Branches      10655    10657       +2     
============================================
+ Hits          31719    31722       +3     
- Misses        42679    42687       +8     
+ Partials       2813     2812       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atorresveiga atorresveiga merged commit d167642 into trunk Jan 17, 2025
19 of 23 checks passed
@atorresveiga atorresveiga deleted the issue/12439-edit-origin-address-navigation branch January 17, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants