[Woo POS][Non-Simple Products] Update Variation Name Display Logic

[AnirudhBhat]

Closes: #13330

Description

This PR updates the logic for displaying the name of variable products. Previously, only the attribute value (e.g., Red) was shown. With this change, both the attribute name and value (e.g., Color:Red) will be displayed for better clarity and user understanding.

Changes

1. Added new getNameForPOS function to include both attribute name and attribute value in the format {name}:{value}.
2. Modified the separator from - to , for a cleaner and more intuitive representation of attributes.
3. Display Parent product name in cart when variation is added to cart.

Steps to reproduce

1. Navigate to POS (more menu -> POS)
2. Click on any variable product
3. Ensure you see variation name in the format {attribute name}:{attribute value}
4. Add variation to cart
5. Ensure you see parent product name, attributes, and price of variation in cart

The tests that have been performed

Tested above mentioned steps in both light and dark mode

Images/gif

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	2f7b30e
	Direct Download	woocommerce-wear-prototype-build-pr13332-2f7b30e.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	2f7b30e
	Direct Download	woocommerce-prototype-build-pr13332-2f7b30e.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 55.55556% with 16 lines in your changes missing coverage. Please review.

Project coverage is 41.11%. Comparing base (f9da72a) to head (2f7b30e).
Report is 26 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...home/items/variations/WooPosVariationsViewModel.kt	50.00%	10 Missing and 5 partials ⚠️
...id/ui/woopos/home/totals/WooPosTotalsRepository.kt	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #13332      +/-   ##
============================================
+ Coverage     41.10%   41.11%   +0.01%     
+ Complexity     6484     6481       -3     
============================================
  Files          1325     1325              
  Lines         77499    77527      +28     
  Branches      10669    10674       +5     
============================================
+ Hits          31856    31876      +20     
- Misses        42814    42819       +5     
- Partials       2829     2832       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samiuelson]

This works well, @AnirudhBhat. I left a couple of questions – let me know what are your thoughts.

[samiuelson]

❓ Shouldn't this be localized?

[AnirudhBhat]

Currently, I believe "Any {attribute name}" is not localised in production as well. The reasoning is that "Any" functions like a generic dropdown option, similar to the other variation choices.

[samiuelson]

Hm. I'm not sure I understand why we don't want to localise it as "Any %s".

"Any {attribute name}" is not localised in production

Do you refer to Woo wp-admin? I think texts in the app are localised independently of the web (e.g. you can have english version of Wordpress on server and the Woo app localised to the language of the OS).

It's also translated on iOS, as you can see here: https://github.com/woocommerce/woocommerce-ios/blame/trunk/Yosemite/Yosemite/Tools/ProductVariations/VariationAttributeViewModel.swift#L53

Let me know in case I'm missing something here @AnirudhBhat.

[AnirudhBhat]

@samiuelson Thanks for the review. I've added localisation only for the POS mode. Let me know what you think!

c5720e0

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 21.5. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[samiuelson]

Thanks for your work @AnirudhBhat. LGTM