Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build should stop if npm fails #4513

Closed
1 task done
netmindz opened this issue Jan 22, 2025 · 0 comments · Fixed by #4556
Closed
1 task done

Build should stop if npm fails #4513

netmindz opened this issue Jan 22, 2025 · 0 comments · Fixed by #4556
Assignees
@netmindz
Labels
bug
Milestone
0.15.1 candidate

Comments

@netmindz
Copy link
Member

What happened?

If npm run build fails, stop the build. Don't give cryptic errors later

To Reproduce Bug

Fail to run npm install

Expected Behavior

Stop on error

Install Method

Self-Compiled

What version of WLED?

Any

Which microcontroller/board are you seeing the problem on?

Other

Relevant log/trace output



Anything else?


No response


Code of Conduct


    

  •  I agree to follow this project's Code of Conduct
    • 


      		
    

      
  





        



            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @netmindz
netmindz




          added
  the 

  bug

 label


      Jan 22, 2025

    

  



    

    

      
    

    


      

          @netmindz
netmindz




          added this to the   0.15.1 candidate milestone


      Jan 22, 2025

    

  



    

    

      
    

    


      

          @netmindz
netmindz




              self-assigned this


      Jan 22, 2025

    

  



  

  

    
  


  

      

    @spiro-c
spiro-c



    mentioned this issue
    
      Feb 15, 2025
    





  


  

      
   Merged

  







  




    

    


  


  
    
  
  

    
  netmindz 

      added a commit
      that referenced
      this issue

    
      Feb 15, 2025
    
    

      


  

    

      


  

      
        @netmindz
  





      

        
          Merge pull request #4556 from spiro-c/npm-check
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          2b9ff31
        
      

    

  

    

      
Fix for: Build should stop if npm fails #4513

    




    

  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @netmindz
  
    netmindz
    

      








      


  


  

    Labels
  



    

      

    bug









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    0.15.1 candidate
  





    
      
          


  

    
      

        
    

    Development
  




          
  
Successfully merging a pull request may close this issue.





    


  
          
      Fix for: Build should stop if npm fails #4513

    
      spiro-c/WLED
    





    
  




      

    

  
      

  

    

      1 participant
    

    

        
          @netmindz