Skip to content

Commit

Permalink
Merge pull request #4556 from spiro-c/npm-check
Browse files Browse the repository at this point in the history
Fix for: Build should stop if npm fails #4513
  • Loading branch information
netmindz authored Feb 15, 2025
2 parents 7f24269 + 778cecb commit 2b9ff31
Showing 1 changed file with 20 additions and 2 deletions.
22 changes: 20 additions & 2 deletions pio-scripts/build_ui.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
Import('env')
Import("env")
import shutil

env.Execute("npm run build")
node_ex = shutil.which("node")
# Check if Node.js is installed and present in PATH if it failed, abort the build
if node_ex is None:
print('\x1b[0;31;43m' + 'Node.js is not installed or missing from PATH html css js will not be processed check https://kno.wled.ge/advanced/compiling-wled/' + '\x1b[0m')
exitCode = env.Execute("null")
exit(exitCode)
else:
# Install the necessary node packages for the pre-build asset bundling script
print('\x1b[6;33;42m' + 'Installing node packages' + '\x1b[0m')
env.Execute("npm install")

# Call the bundling script
exitCode = env.Execute("npm run build")

# If it failed, abort the build
if (exitCode):
print('\x1b[0;31;43m' + 'npm run build fails check https://kno.wled.ge/advanced/compiling-wled/' + '\x1b[0m')
exit(exitCode)

0 comments on commit 2b9ff31

Please sign in to comment.