Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #61

wants to merge 1 commit into from

Conversation

userdocs
Copy link

@userdocs userdocs commented Jan 8, 2025

Using zizmor these errors were resolved in the example workflow.

21 |         - name: Checkout your repository using git
   |  _________-
22 | |         uses: actions/checkout@v4
   | |_________________________________- does not set persist-credentials: false
   |
   = note: audit confidence → Low

error[excessive-permissions]: overly broad workflow or job-level permissions
  --> \\?\I:\repo\.github\workflows\test.yml:12:1
   |
12 | / permissions:
13 | |   contents: read
14 | |   pages: write
15 | |   id-token: write
   | |_________________^ pages: write is overly broad at the workflow level
   |
   = note: audit confidence → High

error[excessive-permissions]: overly broad workflow or job-level permissions
  --> \\?\I:\repo\.github\workflows\test.yml:12:1
   |
12 | / permissions:
13 | |   contents: read
14 | |   pages: write
15 | |   id-token: write
   | |_________________^ id-token: write is overly broad at the workflow level
   |
   = note: audit confidence → High

6 findings (3 suppressed): 0 unknown, 0 informational, 0 low, 1 medium, 2 high

Update README.md

Update README.md
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @userdocs! Could you share how you tested these changes?

@userdocs
Copy link
Author

@delucis it's the link in my comment

https://github.com/woodruffw/zizmor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants