add labels and ability to compare labels/annotations with its values #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tombokombo <[email protected]>
Signed-off-by: tombokombo <[email protected]>
|
@lwei-wish could you please review? thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this PR, introduce same for labels. We need labels becuase you cannot edit kops addons annotations. It allows you to use multiple annotations and multiple lables together to match desired daemonset. It support annotations/lables values as well. Synax for env var is DAEMONSET_ANNOTATION: "key1:val1,key2:val2,key3" key3 without value just check presence of annotation for backward compatibility.