Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-6843] Logging a WARN if a deployment's runtime name doesn't have an extension #6340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WFCORE-6843] Logging a WARN if a deployment's runtime name doesn't have an extension #6340

wants to merge 1 commit into from
+10 −0

Conversation

khermano
Copy link
Contributor

yersan
yersan requested changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@yersan yersan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khermano Check the "Check non-i18n logging" failure, you have to use the proper log classes and add the message using @message, see for example DomainControllerLogger, otherwise your warning messages won't be i18n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khermano @yersan