Separated unicapture

[mariotaku]

Make unicapture (somewhat) separated. This library does great job capturing screen content, and can be used by webos-vncserver: Informatic/webos-vncserver#6 .

Copilot reviewed 8 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (4)

• CMakeLists.txt: Language not supported
• fbs/CMakeLists.txt: Language not supported
• unicapture/CMakeLists.txt: Language not supported
• unicapture/unicapture.c: Language not supported

[sundermann]

Looks good, though I'm wondering if ARGB is needed for VNC. Blending in the alpha channel saves 25% bandwidth at the cost of some computation but it could be worth it.

[sundermann]

I'm not against changing this, but I'm just wondering why it's needed as in my testing the CMAKE_TOOLCHAIN_FILE from the main cmake was not passed automatically when using ExternalProject_Add.

[mariotaku]

On my machine, environment-setup was sourced, so CC environment variable was set. Maybe I could try changing that on my computer instead

[sundermann]

environment-setup is not needed with cmake projects. It's enough to pass the toolchain file only.

[mariotaku]

I just tried a few combination:

1. Set -DCMAKE_TOOLCHAIN_FILE in configuration step: ExternalProject won't have toolchain specified
2. Set CMAKE_TOOLCHAIN_FILE in environment variable (just like sourcing environment-setup): ExternalProject will have that toolchain too

This change seems to be out of scope for this time, so I'll revert the last commit :)

[mariotaku]

@sundermann Yes, for VNC library, it only expects 1/2/4 bytes per pixel. We need to give it XRGB.

[Syspoke]

@mariotaku Hi, is it normal that we no longer have the .so libraries included in the zip artifacts build?
I think we need to copy them from the build/unicapture/ directory now by modifying the build.yml file.
Thanks.

[mariotaku]

@Syspoke Sorry, I have introduced this build issue. I'll fix it in another commit.